Fix check-cfg-related and rust-lld-related CI failures #1110
Conversation
| @@ -63,5 +63,11 @@ members = [ | |||
| missing_debug_implementations = "warn" | |||
| rust_2018_idioms = "warn" | |||
| single_use_lifetimes = "warn" | |||
| unexpected_cfgs = { level = "warn", check-cfg = [ | |||
There was a problem hiding this comment.
seems this warn isn't avoidable, when locally-developing crossbeam itself with any toolchain with the support of Cargo.toml's lints.rust and < nightly-2024-05-19..:
$ RUSTUP_TOOLCHAIN=1.78.0-x86_64-unknown-linux-gnu cargo check
warning: /home/ryoqun/work/crossbeam/Cargo.toml: unused manifest key: workspace.lints.rust.unexpected_cfgs.check-cfg
Compiling crossbeam-utils v0.8.19 (/home/ryoqun/work/crossbeam/crossbeam-utils)
There was a problem hiding this comment.
Btw, we are working on making this warning go away in the current beta with rust-lang/cargo#13925, so that when it reaches stable, the warning would already be gone by the previous version.
well, well, well. celebrate rapid development progress of rust nightly? seems https://blog.rust-lang.org/2024/05/17/enabling-rust-lld-on-linux.html is the culprit for the |
ryoqun
changed the title
|
@taiki-e Following from #1109 (comment), it seems ci is green again in another approach. could you review this? |
Fix master ci, which is broken due 2 problems: